Skip to content

Draft: Feature/clingification rebase2025 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
luketpickering wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Draft: Feature/clingification rebase2025 #45

luketpickering wants to merge 22 commits into from

Conversation

@luketpickering
Copy link
Member

@luketpickering luketpickering commented Oct 23, 2024

Depends on: cafana/SRProxy#22

Probably obviates #43 ... sorry Liam

@luketpickering luketpickering changed the title Feature/clingification rebase2024 Draft: Feature/clingification rebase2024 Oct 23, 2024
@LiamOS
Copy link
Member

LiamOS commented Oct 30, 2024 •
edited
Loading

Apology accepted, this is far more comprehensive.

As a test I made a new package (fairly direct copy of duneanaobj/package.py) for this since it's on your fork. It failed to build due to CMake not finding process_ups_files:

1 error found in build log:
     34    --   * property LINK_OPTIONS for the current scope:
     35    --       SHELL:$<IF:$<PLATFORM_ID:Darwin>,LINKER:-undefined$<COMMA>error,LINKER:--unresolved-symbols=ignore-in-shared-libs>
     36    --   * properties modified at lower-level directories
     37    --   * target- and source-specific directories.
     38    -- Found nlohmann_json: /exp/dune/data/users/losulliv/fnal-spack/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_pla
           ceholder__/__spack_path_placeholder_/nlohmann-json/3.11.2/linux-almalinux9-x86_64_v3-gcc-11.4.1-ih47l44vtqhb5wqmwrnietsxusndpqf6/share/cmake/nlohmann_json/nlohmann_jsonConfig.cmake (found suitable version "3.11.2", minimum required is "3.11.2"
           )
     39    -- Found Vdt: /exp/dune/data/users/losulliv/fnal-spack/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__/__spack_path_placeholder__
           /__spack_path_placeholder_/vdt/0.4.4/linux-almalinux9-x86_64_v3-gcc-11.4.1-zabwhosayl2qvcd5mpjr6mzuiynetdh6/include (found version "0.4")
  >> 40    CMake Error at ups/CMakeLists.txt:2 (process_ups_files):
     41      Unknown CMake command "process_ups_files".
     42    
     43    
     44    -- Configuring incomplete, errors occurred!

See build log for details:
  /tmp/losulliv/spack-stage/spack-stage-lukeanaobj-03_06_00-zs366jkvyoy7vbelo2toyb6o65l72sym/spack-build-out.txt

Can help debug further if needed.

@tomjunk
Copy link
Member

tomjunk commented May 27, 2025

Sorry to be very neglectful here! cafana/SRProxy#22 still looks unmerged. Is this PR still being worked on?

Luke Pickering and others added 20 commits October 29, 2025 13:12
Adds parallel standalone build which is dependent on the TCling versi…
748b9fc 
…on of GenSRProxy -- pulled in via cmake. Not production ready, but please test!
fix readme md typo
62e7535
Fix include dir for when this project is included in others.
71a2e92
Actually fix paths. Increase verbosity when generating proxies.
8203ac0
Add duneanaobj interface target, fix some header installations
b75f510
Fixes usage of some imported SRProxy targets and updates target branch
80b17a9
Flat Reader is now built for STANDALONE_BUILD=ON
34ecaa6
Fixes some CMake target linking and exporting
5de609e 
* Should now produce a useable `duneanaobjConfig.cmake` when built with
  `STANDALONE_BUILD=ON`
Improved installed config, adds some test apps
ec34fbf 
* Adds duneanaobjConfig.cmake and setup.duneanaobj.sh files that support
  dependent builds/code finding the build products of this package
* Removes no-long-neccessary preprocessor guards for code that scared
  castxml
* Adds git shorthash and semantic version fields to the SR for easier
  provenance
* Adds a test app that writes out a single dummy event
* Begins an app for dumping the event content to stdout, needs work.
adds the standardrecord implementation template
edbaa59
Rebases clingification changes on to Oct23 master HEAD of duneanaobj
cce7f0e
tidy duneanaobj object version and shorthash cmake variable names
9c5df3d
Properly exports targets again
964fbff
fix some include directories for fetchcontent inclusion
17b0818
fixes wrong dependency in flat
8492ad8
just explicitly instantiate Proxy<StandardRecord>
4f1b5d4
remove unneccessary epilog now that SR proxy properly instantiates en…
7f9fff1 
…countered enum types
improve target include directories
b67749c
install the StandardRecord headers...
1f74f5e
adds optional proxy python binding generation
5b7db8f
@luketpickering luketpickering force-pushed the feature/Clingification_rebase2024 branch from 4d3fb26 to 5b7db8f Compare October 29, 2025 13:14
@luketpickering luketpickering changed the title Draft: Feature/clingification rebase2024 Draft: Feature/clingification rebase2025 Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luketpickering @LiamOS @tomjunk